Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Allow Firo to send to an EXX address. #3119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dev-warrior777
Copy link
Contributor

@dev-warrior777 dev-warrior777 commented Dec 11, 2024

- EXX addresses are used for Firo and other privacy coins to
  send funds to  Binance and other exchanges due to last US
  administration regulations.
  • This PR makes a non-standard P2PKH script to enable this.

	EXX addresses are used for Firo and other privacy coins to
	send funds to  Binance and other exchanges due to last US
	administration regulations.
@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 11, 2024

Dex Electrum Firo => Binance

image

@dev-warrior777
Copy link
Contributor Author

Working using Dex Electrum Firo wallet. And can send to Binance and to Firo full node.

  • Todo: Test on Dex Firo full-node.

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 12, 2024

Dex full-node => Binance Tx

2024-12-12 14:53:07.987 [DBG] CORE[firo]: 2 signature cycles to converge on fees for tx 48447697517d82f177143962b8c98904208bd09c8ff743bd4672198c5ed1a824: min rate = 1, actual fee rate = 1 (226 for 226 bytes), change = true
2024-12-12 14:53:08.000 [INF] CORE: notify: |SUCCESS| (send) Send successful - Sending 0.33300000 firo to EXXKcAcVWXeG7S9aiXXGuGNZkWdB9XuSbJ1z has completed successfully. Tx ID = 48447697517d82f177143962b8c98904208bd09c8ff743bd4672198c5ed1a824:0

image

@dev-warrior777 dev-warrior777 marked this pull request as ready for review December 12, 2024 15:03
	- Add testnet tests
	- Add more Documentation
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at an older commit of yours when I started this, but check out this variation please.

buck54321/dcrdex@0030e49...buck54321:dcrdex:exx-addr-interface

@dev-warrior777
Copy link
Contributor Author

I was looking at an older commit of yours when I started this, but check out this variation please.

buck54321/dcrdex@0030e49...buck54321:dcrdex:exx-addr-interface

Thanks for this. The logic did not change between c6db64d and 7a86357, just additional tests & cleanup, so your suggestion is welcome.

Please believe me when I say I considered making an interface to identify the user of the PayToAddrScript(addr) before I went the other route. My concern was always to minimize any footprint in common code and your code does this better. It is also less C-like than mine and solves the issue of the address encoding information being "lost" in btcutil.Address . More elegant.

Let me take a look today and send some more Firo to Binance. I also want to keep a couple of other currently unused byte constants for normal transparent addresses around for future use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants