-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Allow Firo to send to an EXX address. #3119
base: master
Are you sure you want to change the base?
Conversation
dev-warrior777
commented
Dec 11, 2024
•
edited
Loading
edited
- This PR makes a non-standard P2PKH script to enable this.
EXX addresses are used for Firo and other privacy coins to send funds to Binance and other exchanges due to last US administration regulations.
Working using
|
|
- Add testnet tests - Add more Documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at an older commit of yours when I started this, but check out this variation please.
buck54321/dcrdex@0030e49...buck54321:dcrdex:exx-addr-interface
Thanks for this. The logic did not change between c6db64d and 7a86357, just additional tests & cleanup, so your suggestion is welcome. Please believe me when I say I considered making an interface to identify the user of the PayToAddrScript(addr) before I went the other route. My concern was always to minimize any footprint in common code and your code does this better. It is also less C-like than mine and solves the issue of the address encoding information being "lost" in Let me take a look today and send some more Firo to Binance. I also want to keep a couple of other currently unused byte constants for normal transparent addresses around for future use. |