client: Use the app build version as Version in UI in hamburger menu. #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is a rework of decred#3096 and keeps the Build ID in the settings dialog. - Webpack Build ID for caching site/dist build will be addressed in another PR if required.
martonp
reviewed
Dec 15, 2024
There was a problem hiding this comment.
You can simplify a bit like @JoeGruffins was saying in the previous PR like this: 6d81766
Also, IMO, the version should just be on the settings page. It looks a little cluttered on the hamburger menu.
Btw, the commit message should be descriptive of what's done in the commit, right now it's more of a communication to people who have been reviewing the PR and already know what's going on. And please link the issue that this resolves.
|
|
Done |
martonp
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Issue #3091