pool: Correct account races. #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The account and name fields of a client are not set until they are received via a mining.authorize message and the account field is accessed from separate goroutines which is a race. This corrects that issue by introducing a separate mutex to protect both the account and the name field and updating all references to by protected by the mutex accordingly. The name field doesn't appear to be used anywhere currently, however, it would also be a race to access it without the mutex for the same reason, so this takes the opportunity to ensure it is protected in case it is used in the future.
jholdstock
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account and name fields of a client are not set until they are received via a mining.authorize message and the account field is accessed from separate goroutines which is a race.
This corrects that issue by introducing a separate mutex to protect both the account and the name field and updating all references to by protected by the mutex accordingly.
The name field doesn't appear to be used anywhere currently, however, it would also be a race to access it without the mutex for the same reason, so this takes the opportunity to ensure it is protected in case it is used in the future.
Fixes #374.