pool: Do not populate/use gentx2. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the pool to report the entire partial header via the first generation tx field as intended and no longer populates the second generation tx field since it does not apply to Decred. Some of the old ASICs hacked the stake version in there, but that is really not something that should have ever been done because the stratum "protocol" (which is not actually very well defined) already does not individually provide all of the information the Decred header needs nor does it provide an official way to extend it. Further, the Decred header explicitly provides additional space which removes the need to create a new coinbase and update the merkle root. So, in order to address these things, the field that was intended to serve for the coinbase (generate transaction) was repurposed to contain the serialized partial header for data after the previous block hash in the format it is to be hashed. Therefore, it should be providing the entire remaining partial header to ensure that any future modifications to the end of the header are available to miners without modification. Given that the old ASICs no longer work with the network, this takes the opportunity to make the change.
davecgh
force-pushed
the
pool_no_gentx2
branch
from
aac0e56
to
99d71b5
Compare
jholdstock
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the pool to report the entire partial header via the first generation tx field as intended and no longer populates the second generation tx field since it does not apply to Decred.
Some of the old ASICs hacked the stake version in there, but that is really not something that should have ever been done because the stratum "protocol" (which is not actually very well defined) already does not individually provide all of the information the Decred header needs nor does it provide an official way to extend it.
Further, the Decred header explicitly provides additional space which removes the need to create a new coinbase and update the merkle root.
So, in order to address these things, the field that was intended to serve for the coinbase (generate transaction) was repurposed to contain the serialized partial header for data after the previous block hash in the format it is to be hashed. Therefore, it should be providing the entire remaining partial header to ensure that any future modifications to the end of the header are available to miners without modification.
Given that the old ASICs no longer work with the network, this takes the opportunity to make the change.