Prep for dual network support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Oct 12, 2023
The new crawler struct contains its own reference to an address manager instance rather than using the global reference. This opens the possibility of multiple crawlers using different address managers in the future.
The web server only needs a reference to an address manager once (during initialization) so it can be passed as a parameter and the global var can be removed.
The new server struct is initialized and run as two distinct steps. Any errors during initialization (eg. port already in use) will cause dcrseeder to exit. The run function is blocking and returns when the provided context is canceled.
Rather than using the default global logger provided by the log package,
initialize a logger with a prefix to indicate the network dcrseeder is
running on ("[mainnet]" or "[testnet]"). Pass that logger around as a
parameter and use it in all subsystems.
Config validation/prep was split between the loadConfig func and the main func. This consolidates it into loadConfig.
Any tasks deferred in the main func will not execute if os.Exit is called. Moving application logic down into a new func which is called by main works around this limitation.
davecgh
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a working diff to run a single instance of dcrseeder on mainnet and testnet simultaneously (#14). The commit which adds dual network support is reasonably large on its own, so to ease reviewing I have opened this preliminary PR which is some the necessary prep work.