Renaming of slice variables to slab - Fixes issue #21 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Christopher McLean to list of contributors.
Removed slice naming from file: slice --> slab, time_slice --> slab_range, slice_index --> slab_points.
Removed slice naming from file: slice --> slab, time_slice --> slab_range, slice_index --> slab_points, self.slices --> self.slabs, self.sample_slice --> self.sample_slab, slices --> slabs.
Removed slice naming from file: slice --> slab, self.slices --> self.slabs.
Slice rename
|
It appears you will have to include: "CMU License (MIT-CMU)" for a new dependency of matplotlib to pass the license check. See list of authorized licenses here: https://github.com/decryptofy/scarr/blob/main/license_check.ini |
Added CMU License (MIT-CMU) to the list of authorized licenses.
|
Added CMU License (MIT-CMU) to the list of authorized licenses. |
|
Thanks, I checked this with the first Jupyter notebook and everything still works as it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the container.py, trace_handler.py, and correlation_data.py files, the variable name slice shadows the built-in Python function slice. In order to avoid errors and confusion, the following variable name changes were made:
slice --> slab
slices --> slabs
time_slice --> slab_range
slice_index --> slab_points
batch_slice -->batch_slab
self.sample_slice --> self.sample_slab
self.slices --> self.slabs
Additionally, Christopher McLean was added to the list of contributors in README.md.