Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
While training a
Gazetteer
on data with aperson
field and no other name field, I noticed that predicates likePartialIndexLevenshteinSearchPredicate: (3, best_looking_name, CorporationName)
were wrongly generated as well as the expectedPartialIndexLevenshteinSearchPredicate: (3, best_looking_name, Surname)
.This happens because
block_parts
were not properly set when initialization of theWesternNameType
depending on theWesternNameType.name_type
Changes
Fixed
WesternNameType
, appropriately set theblock_parts
depending on theWesternNameType.name_type
before calling the parentParseratorType.__init__