-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example based #166
Merged
Merged
Example based #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Hervier <lucas.hervier@irt-saintexupery.com>
Co-authored-by: Lucas Hervier <lucas.hervier@irt-saintexupery.com>
Co-authored-by: Lucas Hervier <lucas.hervier@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Closed
Co-authored-by: Adelin Constans <adelin.constans@irt-saintexupery.com> Co-authored-by: Lucas Hervier <lucas.hervier@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
Co-authored-by: Antonin Poché <antonin.poche@irt-saintexupery.com>
…sitional arguments
AntoninPoche
force-pushed
the
example-based
branch
from
October 7, 2024 16:19
ba1a174
to
5bd707b
Compare
lucashervier
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything was already discussed and treated in PR #165 . As it is the same PR with cleaned commits I approve without further comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #165 but with a clean commit history.
Introduce the Example-based module
This pull request introduces example-based methods from four families of methods. Namely:
The API
The API is common for the four families, and it has three steps: