Layers page #31
Layers page #31
Conversation
There was a problem hiding this comment.
@Yukino2002 Can you review this PR?
@maithili232 Can you put up screenshots of what this looks like?
| @@ -227,3 +228,49 @@ footer { | |||
| @apply pb-4; | |||
| } | |||
| } | |||
|
|
|||
| /* layers page */ | |||
There was a problem hiding this comment.
If you are using the exact same styling, you can just reuse the classes. No need to redeclare with a different class name.
| @@ -0,0 +1,53 @@ | |||
| import Image from "next/image"; | |||
There was a problem hiding this comment.
This component is also exactly the same as Models/FilterButton.jsx. Please reuse the component, maybe move it to a directory named Common and use it in both models and layers page.
| const Layers = () => { | ||
|
|
||
| const [filteredLayers, setFilteredLayers] = useState(layers); | ||
| const [models, setModels] = useState([]); |
There was a problem hiding this comment.
I am not sure what models exactly are in the layers page, is the naming intended?
There was a problem hiding this comment.
Models that use the layers so layers can be filtered with their respective models.
|
Please add the layers page as a card in the landing page or button in the navigation bar, so that it is accessible to users. |
|
@maithili232 Added a few comments, will check on local once the comments have been addressed. |
| @@ -0,0 +1,59 @@ | |||
| import Image from "next/image"; | |||
| import Link from "next/link"; | |||
There was a problem hiding this comment.
This component is also very similar. I think some part has been omitted out, but I think can be reused.
Sharing few screenshots : |
I have added the layers on the index page like this : |
Added layers page to the website. Followed the same pattern of model page.