Upload pdf to s3 #38
Upload pdf to s3 #38
Conversation
| if __name__ == "__main__": | ||
| os.system("mkdir " + PDF_PATH) | ||
| html_to_pdf() | ||
| merge_pdf() | ||
| compile_information_pages() | ||
| merge_pdf_pages(['storage/title.pdf', 'storage/acknowledgement.pdf', 'storage/contents.pdf', 'storage/full_pdf.pdf']) | ||
| merge_pdf_pages(['storage/title.pdf', 'storage/acknowledgement.pdf', 'storage/contents.pdf', 'storage/merged.pdf']) | ||
| upload_file('storage/full_pdf.pdf', 'deepchemtutorials', 'TutorialsBook.pdf') |
There was a problem hiding this comment.
pls, keep an empy line at the end
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
There was a problem hiding this comment.
same here, pls add an empty last line.
| @@ -5,6 +5,7 @@ | |||
| - pdfunite | |||
| - pdfkit | |||
| - mdpdf | |||
| - boto3 | |||
There was a problem hiding this comment.
please add boto3 to requirements file
| @@ -0,0 +1,42 @@ | |||
| name: Build latest version of PDF Book | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
Looks good, can you please explain when exactly this workflow will get triggered.
There was a problem hiding this comment.
Yes, the workflow will be triggered whenever new commits are performed in examples/tutorials directory in deepchem repository.
| import json | ||
|
|
||
|
|
||
| class TestConvertHTMLToPDF(unittest.TestCase): |
There was a problem hiding this comment.
Add a docstring to this class (use numpydoc style)
|
|
||
| class TestConvertHTMLToPDF(unittest.TestCase): | ||
|
|
||
| def test_convert_html_to_pdf(self): |
| os.rmdir("mocks/mock_temp_storage") | ||
|
|
||
|
|
||
| class TestMergePDF(unittest.TestCase): |
Since the function html_to_pdf converts the html files to pdf, we need some mock html files to unit test this functionality. So for testing that I have added mock-html notebooks folder which contains sample html-files. |
Title: Automated Book build and Upload to S3.
Changes Made: