Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added javadoc hinting at why emmin and emmax op rates are so different #255

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
/**
* Standard tests for the updateBy table operation. Calculates a tick-based exponential moving maximum for specified
* columns and places the result into a new column for each row.
* <p/>
* Note: When there are no Group Keys, EmMaxTick has a much faster rate than EmMinTick. This is likely because of branch
* prediction on x86 systems. This disparity does not happen on Mac M1.
*/
public class EmMaxTickTest {
final StandardTestRunner runner = new StandardTestRunner(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
/**
* Standard tests for the updateBy table operation. Calculates a time-based exponential moving maximum for specified
* columns and places the result into a new column for each row.
* <p/>
* Note: When there are no Group Keys, EmMaxTime has a much faster rate than EmMinTime. This is likely because of branch
* prediction on x86 systems. This disparity does not happen on Mac M1.
*/
public class EmMaxTimeTest {
final StandardTestRunner runner = new StandardTestRunner(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
/**
* Standard tests for the updateBy table operation. Calculates a tick-based exponential moving minimum for specified
* columns and places the result into a new column for each row.
* <p/>
* Note: When there are no Group Keys, EmMinTick has a much slower rate than EmMaxTick. This is likely because of branch
* prediction on x86 systems. This disparity does not happen on Mac M1.
*/
public class EmMinTickTest {
final StandardTestRunner runner = new StandardTestRunner(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
/**
* Standard tests for the updateBy table operation. Calculates a time-based exponential moving minimum for specified
* columns and places the result into a new column for each row.
* <p/>
* Note: When there are no Group Keys, EmMinTime has a much slower rate than EmMaxTime. This is likely because of branch
* prediction on x86 systems. This disparity does not happen on Mac M1.
*/
public class EmMinTimeTest {
final StandardTestRunner runner = new StandardTestRunner(this);
Expand Down