Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhoc benchmarks from deephaven core branch #275

Merged
merged 28 commits into from
Mar 26, 2024
Merged

Adhoc benchmarks from deephaven core branch #275

merged 28 commits into from
Mar 26, 2024

Conversation

stanbrub
Copy link
Collaborator

  • Improved Adhoc Benchmarking by allowing Deephaven-Core :: to be specified as well as existing images
  • Use existing Workflow UI Image field for either option (image or branch)
  • Build image in the case where :: is specified
  • Run adhoc against image, whether supplied or built, and publish results to GCloud Benchmark bucket as usual
  • Removed "mvn verify" from the runner-side workflow, since it was happening twice
    • Pull jar artifacts from the Benchmark test server instead of from the GH runner
  • Added setup for update-alternatives to support multiple versions of Temurin Java JDK
  • Added --force and kill to fix an issue with deleting referenced containers

stanbrub added 28 commits March 20, 2024 16:15
@stanbrub
Added support for supplying branch name in place of image for adhoc runs
bbcc7ed
@stanbrub
sigh. Mispelled script name
a472a5d
@stanbrub
Add correct directories for docker compose pull
f7b9e66
@stanbrub
Updated docker compose files with variables
739174e
@stanbrub
Get jars from remote for artifact
c154485
@stanbrub
Fixed issue with slack publish
d5e2af0
@stanbrub
Changed ssh to https for cloning for building docker image
223a63c
@stanbrub
Fixed deephaven server docker URL
ac3fb26
@stanbrub
Added Temurin JDK install
88c3958
@stanbrub
Added JDK checking and installation to Benchmark server setup
75b22ef
@stanbrub
Added promptless apt jdk install
27846fa
@stanbrub
Don't enforce set -u
9a80b26
@stanbrub
Specify build java
af1d9f1
@stanbrub
Be more forceful in purge docker stuff
8b05e61
@stanbrub
Added some debug lines
522af53
@stanbrub
More build issues experiments
a845d1b
@stanbrub
Split up the DH distribution build and the docker image build
baa7860
@stanbrub
Workflow syntax error
1e469c7
@stanbrub
Sigh
025f5de
@stanbrub
Fixed the checked location of DH version
21ae73a
@stanbrub
Fixed another path issue
3e5561d
@stanbrub
More GH workflow conditions
d7cafd0
@stanbrub
More GH workflow conditions
b83571b
@stanbrub
More GH workflow conditions
0bcbfae
@stanbrub
Removed force from docker stop
2c7148c
@stanbrub
More GH workflow trial and error
57b03d2
@stanbrub
Reworked the GH workflow to separate conditional builds from start/stop
6190267
@stanbrub
Fixed argument order managing docker up down
b0a2ebf
@stanbrub stanbrub self-assigned this Mar 26, 2024
@stanbrub stanbrub linked an issue Mar 26, 2024 that may be closed by this pull request
Benchmark Server JDK Consistency #273
Closed
This was linked to issues Mar 26, 2024
Docker Cleanup Error Removing Non-Existent Container #274
Closed
Run Benchmark Tests on a Given Branch #92
Closed
@stanbrub stanbrub merged commit f871c1b into deephaven:main Mar 26, 2024
2 checks passed
@stanbrub stanbrub deleted the adhoc-benchmarks-from-deephaven-core-branch branch March 26, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stanbrub stanbrub

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@stanbrub