refactor: no-ticket: make DeferredColumnRegionBase more efficient wrt volatile #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
malhotrashivam and
cpwright
and removed request for
malhotrashivam
devinrsmith
changed the title
rcaudy
reviewed
Feb 3, 2025
| @@ -33,39 +32,33 @@ public abstract class DeferredColumnRegionBase<ATTR extends Any, REGION_TYPE ext | |||
| public void invalidate() { | |||
| super.invalidate(); | |||
| synchronized (this) { | |||
| if (resultRegion != null) { | |||
| resultRegion.invalidate(); | |||
| REGION_TYPE localResultRegion; | |||
There was a problem hiding this comment.
I don't think this case actually needs a lock as written. But maybe we should keep is this way and null out the result region after invalidating?
There was a problem hiding this comment.
I'm not sure about this.
- Keeping a non-null, invalidated result in place makes the invalidation sticky.
getResultRegion()isn't checking if we're invalidated, so if we were to null out the result we might create a new one. But that could also happen ifinvalidate()were to be called before the first call togetResultRegion().
There was a problem hiding this comment.
I didn't try to dig any deeper into the intentions. As my PR stands, it's a pure refactor that preserves the existing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.