Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #166

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update release instructions #166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577cf01
Update release instructions
kosak Dec 8, 2023
31962c0
lowercase version
kosak Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ The release will proceed with [GitHub Actions](https://github.com/deephaven/deep
Upon completion, the publish workflow will upload the jars as artifacts. There should be 7 jars in total:
`deephaven-csv`'s `.jar`, `-javadoc.jar`, `-sources.jar`, and `-jmh.jar`; `deephaven-csv-fast-double-parser`'s `.jar`,
`-javadoc.jar`, and `-sources.jar`. Download these artifacts for later upload as part of the GitHub release.
There will be an 8th jar, buildSrc.jar, which does not need to be included in the release.

### 5. Maven Central jars

Expand Down Expand Up @@ -102,7 +103,7 @@ The main branch is explicitly updated (instead of going through a squash and mer
$ git checkout main
$ git merge --ff-only vX.Y.Z
# edit gradle.properties, bump version, add -SNAPSHOT
# for example v0.12.0 might become v0.13.0-SNAPSHOT
# for example "VERSION=0.12.0" might become "VERSION=0.13.0-SNAPSHOT"
devinrsmith marked this conversation as resolved.
Show resolved Hide resolved
$ git add .
$ git status -uno
$ git commit -m "Version A.B.C-SNAPSHOT"
Expand All @@ -117,6 +118,7 @@ Create a new [GitHub release](https://github.com/deephaven/deephaven-csv/release

The convention is to have the Release title of the form `vX.Y.Z` and to autogenerate the release notes in comparison to the previous release tag.

Upload the 7 jar artifacts downloaded from the publish workflow as assets for the release.
Upload the 7 jar artifacts downloaded from the publish workflow as assets for the release. As a reminder, the 8th jar, buildSrc.jar, does not
need to be uploaded to the release.

Hit the GitHub "Publish release" button.