Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add server and client specific installs #45

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

jnumainville
Copy link
Collaborator

Fixes #44
As of opening this I was able to test all the directions except for the first example in section Displaying Tables from a Remote Server. It should work, something is probably wrong with my setup that I need to figure out.

@jnumainville jnumainville requested a review from mofojed July 25, 2024 19:40
@jnumainville
Copy link
Collaborator Author

Error I was encountering should be fixed by deephaven/deephaven-core#5848

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just think we should clarify deephaven-server vs. pydeephaven right at the top. Looks great, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jnumainville and others added 2 commits July 29, 2024 08:39
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@jnumainville jnumainville merged commit 180a395 into deephaven:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement to install deephaven-server
2 participants