Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCK-12] Draft: Init API with API-E2E #13

Closed
wants to merge 1 commit into from
Closed

[DCK-12] Draft: Init API with API-E2E #13

wants to merge 1 commit into from

Conversation

santhitak
Copy link
Contributor

#12

@santhitak santhitak changed the title Init API with API-E2E [DCK-12] Draft: Init API with API-E2E Jan 5, 2024
Copy link
Collaborator

@spicyzboss spicyzboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I guess the API we will have a lot of applications inside it, pls make the api/ be a group folder then create the application inside it like api/authentication/ or api/generation/

We use the ESM instead of CommonJS, and we will avoid to use Webpack cause of the newer practice and tools is pointing to Vite but the API may use the SWC pls try changing to these.

And would be great if application level only have an entrypoint for the application and move the logics inside the libs/ folder like libs/api/feature-auth or libs/api/shared/data-access-*.

Anyways thanks for help me to make this project better. But the Monorepo practice are lots like the future dependencies, we should make the foundation strong. Then pls take a look for these links to help you easy to understand the concepts.

https://nx.dev/concepts/more-concepts/applications-and-libraries
https://nx.dev/concepts/more-concepts/library-types
https://nx.dev/concepts/more-concepts/grouping-libraries

.prettierrc Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@santhitak santhitak closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants