Skip to content

feat: release v1 (#8) #78

feat: release v1 (#8)

feat: release v1 (#8) #78

Triggered via push February 23, 2024 20:29
Status Failure
Total duration 33s
Artifacts

ci.yml

on: push
Run Integration Tests
22s
Run Integration Tests
Lint Commit Messages
13s
Lint Commit Messages
Fit to window
Zoom out
Zoom in

Annotations

1 error and 2 warnings
Lint Commit Messages
You have commit messages with errors ⧗ input: feat: inheriting cliffed OZ Vesting Wallet and using constants approach (#5) According to [Connext Forum](https://forum.connext.network/t/rfc-partnership-token-agreements/938), the agreement that Wonderland, Veil and Bootload (other partners have), unlocks at the same time, for every partner, one year after launch, a date that we all know (sept 5th 2023), and have the same 1/13ths schedule. So, inputting `startTime` at constructor makes no logic, since that's sth that can be shared accross all partners, this PR aims to reduce that unnecessary constructor argument. In the process of crafting this PR, a test failed hinting me that we missed a big issue, we need to use Llamapay V2. Luckily, this means no contract changes, and only to the test suite, but because of this test, we've realized that we almost failed BIG time. Pushing this PoC with some TODOs in the codebase, the constructor args are gonna be only beneficiary and amount (only thing that differs between partners), and in the testing suite, we need to be using LlamaPay v2. Let's do this approach: - import the Deploy script in the Integration tests - generically test `ConnextVestingWallet` using portions of `TOTAL_AMOUNT()` (and not precise numbers) - specify test `LlamaVesting` showing the expected limiting behaviours: - launch date - launch + 1yr - 1 - launch + 1yr (e.g. `assertEq(.., 1_920_000 ether)`) - launch + 1yr + 1mth - launch + 1yr + 1yr ![image](https://github.com/defi-wonderland/connext-vesting/assets/84595958/13d698a9-7c29-459b-9121-dd3f7d93d712) The way to do this test is probably run it, see the failing expectations, and input what's expected to receive in the tests, right? like, too lazy to calc, but that's a good thing!! the fact that the dev KNOWS and inputs the expected amount at each date, means that there are no doubts about what's expected to happen, please declare those expectations as `x ether` numbers (having a max delta of `1 ether`) --------- Co-authored-by: Dristpunk <dristpunk@gmail.com> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
Lint Commit Messages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Integration Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.