Add support for WASM OCI image in spin #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2023
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
oci-artifacts
branch
from
ee950e8
to
62247b3
Compare
|
bumped this to use the new push feature in fermyon/spin#1882, once spin 2.0 comes out it will have the necessary changes required for the wasm OCI image support |
jsturtevant
changed the title
|
spin 2.0 merged in #177 so will refresh this soon 🥳 |
|
since so much changed, I just opened a new PR #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that demonstrates how OCI artifacts could be used with a runtime that requires a configuration file. It seems spin is dependent on a file system layout which this PR re-creates based on the current way spin works with OCI. There might be a better approach with some changes to spin. Opening it up as it has been a common question. Open to ideas to make things better!
This PR requires changes to spin (todo: links issues in spin), containerd/runwasi#147 and containerd/containerd#9142 (being backported to containerd 1.6 and 1.7) which have the oci artifact support.