quay.io tags list pagination broken: link now properly returns last query parameter

[thomas-riccardi]

(Coming here from Dependabot that miss a bump of FROM quay.io/keycloak/keycloak:25.0.1 Dockerfile (there is a tag 25.0.2))

There is a special case for quay.io registry:

docker_registry2/lib/registry/registry.rb

Line 264 in 2071379

link_key = @uri.host.eql?('quay.io') || @uri.host.eql?('registry.access.redhat.com') ? 'next_page' : 'last'

it comes from #63, from #56, from dependabot/dependabot-core#3989

But at least now, the quay.io api does return a standard link header with last query parameter:

$ curl -I https://quay.io/v2/keycloak/keycloak/tags/list
HTTP/2 200 
date: Thu, 01 Aug 2024 14:49:55 GMT
content-type: application/json
content-length: 1043
server: nginx/1.22.1
link: </v2/keycloak/keycloak/tags/list?n=100&last=23.0.4-0>; rel="next"
vary: Cookie
x-frame-options: DENY
strict-transport-security: max-age=63072000; preload

The quay.io ticket was closed automatically, but the issue seems solved.

=>
#63 should probably be reverted; and in fact the remaining part for the redhat registry too: #92 : it seems also fixed there:

$ curl -I https://registry.access.redhat.com:443/v2/ubi8/ubi-minimal/tags/list
HTTP/1.1 200 OK
Content-Length: 1579
Content-Type: application/json
Link: </v2/ubi8/ubi-minimal/tags/list?n=100&last=8.7-1031-source>; rel="next"
Strict-Transport-Security: max-age=63072000; preload
X-Frame-Options: DENY
Expires: Thu, 01 Aug 2024 14:58:23 GMT
Cache-Control: max-age=0, no-cache, no-store
Pragma: no-cache
Date: Thu, 01 Aug 2024 14:58:23 GMT
Connection: keep-alive

=> I'm opening a PR soon.