Updates docker_registry2 from 1.18.0 to 1.18.2 to fix quay.io container registry pagination

[thomas-riccardi]

What are you trying to accomplish?

what: Fix #10347: fix quay.io container registry pagination, cf deitch/docker_registry2#106

how: Updates docker_registry2 from 1.18.0 to 1.18.2 (I copied the diff from #10480)

Anything you want to highlight for special attention from reviewers?

Automatic dependabot PRs don't seem to be merged, so I try a manual PR.

Updates docker_registry2 from 1.18.0 to 1.18.2

Commits

• b830597 bump 1.18.2 (#108)
• 2915d80 Fix pagination for tags list pagination for quay.io & registry.access.redhat....
• 2071379 remove gemfile.lock from gitignore and commit to git (#105)
• c33e9f5 v1.18.1 (#104)
• 4d4b968 Smartly join URLs (#101)
• d11771a Enhancement of rubocop and tests configs (#103)
• 4c130c9 Fix rubocop on master (#102)
• See full diff in compare view

How will you know you've accomplished your goal?

cf issue #10347

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[yeikel]

Although this

dependabot-core/common/dependabot-common.gemspec

Line 33 in f238da5

spec.add_dependency "docker_registry2", "~> 1.18.0"

definition covers this change, we should consider upgrading there instead

[thomas-riccardi]

ok, I have pushed commits with the modification in dependabot-core/common/dependabot-common.gemspec, and also manually in Gemfile.lock and updater/Gemfile.lock.
Unsure about all that, notably about Gemfile.lock.
I'm not a ruby developer, I'm not familiar with the ruby packaging, but docker_registry2 1.18.0..1.18.2 has no dependency change (except dev dependency), so it should be ok to patch the Gemfile.lock manually.

[thomas-riccardi]

Sorbet check fails, I cannot reproduce the correct environment, to run the suggested bin/tapioca gem: bundle exec tapioca gem --verify

$ bin/docker-dev-shell bundler
 > image dependabot/dependabot-core-development-bundler already exists

=> running docker development shell
[dependabot-core-dev] ~ $ cd dependabot-updater/
[dependabot-core-dev] ~/dependabot-updater $ bundle exec tapioca gem --verify
bundler: failed to load command: tapioca (/home/dependabot/bin/tapioca)
/usr/local/lib/ruby/site_ruby/3.3.0/bundler/rubygems_integration.rb:265:in `block in replace_bin_path': can't find executable tapioca for gem tapioca. tapioca is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)

[targylyen]

@thomas-riccardi should that work against branch main as well ? cause this is what I'm getting:

dependabot-core % git branch
* main
dependabot-core % ./bin/docker-dev-shell bundler
 > image dependabot/dependabot-core-development-bundler already exists

=> running docker development shell
[dependabot-core-dev] ~ $ cd dependabot-updater/
[dependabot-core-dev] ~/dependabot-updater $ bundle exec tapioca gem --verify
bundler: failed to load command: tapioca (/home/dependabot/bin/tapioca)
/usr/local/lib/ruby/site_ruby/3.3.0/bundler/rubygems_integration.rb:265:in `block in replace_bin_path': can't find executable tapioca for gem tapioca. tapioca is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/rubygems_integration.rb:304:in `block in replace_bin_path'
        from /home/dependabot/bin/tapioca:6:in `<top (required)>'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli/exec.rb:58:in `load'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli/exec.rb:58:in `kernel_load'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli/exec.rb:23:in `run'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli.rb:455:in `exec'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli.rb:35:in `dispatch'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/cli.rb:29:in `start'
        from /usr/local/lib/ruby/gems/3.3.0/gems/bundler-2.5.16/exe/bundle:28:in `block in <top (required)>'
        from /usr/local/lib/ruby/site_ruby/3.3.0/bundler/friendly_errors.rb:117:in `with_friendly_errors'
        from /usr/local/lib/ruby/gems/3.3.0/gems/bundler-2.5.16/exe/bundle:20:in `<top (required)>'
        from /usr/local/bin/bundle:25:in `load'
        from /usr/local/bin/bundle:25:in `<main>'

[thomas-riccardi]

@targylyen I have no idea, I'm just trying to bump a dependency on dependabot-core to get a fix, I'm not a ruby developer.

[lewis-strong]

@targylyen I have no idea, I'm just trying to bump a dependency on dependabot-core to get a fix, I'm not a ruby developer.

I've created a PR on your fork to hopefully update this to sort the pipeline sorbet failure

[lewis-strong]

@targylyen I have no idea, I'm just trying to bump a dependency on dependabot-core to get a fix, I'm not a ruby developer.

I've created a PR on your fork to hopefully update this to sort the pipeline sorbet failure

Once you've done that you should rebase this PR too

[targylyen]

@targylyen I have no idea, I'm just trying to bump a dependency on dependabot-core to get a fix, I'm not a ruby developer.

I've created a PR on your fork to hopefully update this to sort the pipeline sorbet failure

Once you've done that you should rebase this PR too

@thomas-riccardi are you able to take a look at this ?

[lewis-strong]

Alternatively I've opened #10855 which includes these changes and the Sorbet tests are now passing

[thomas-riccardi]

@lewis-strong
I'm fine with closing here and just use you PR #10855: I don't know how to review your commit.
But if you prefer, I can rebase here to latest master

[lewis-strong]

@lewis-strong
I'm fine with closing here and just use you PR #10855: I don't know how to review your commit.
But if you prefer, I can rebase here to latest master
That's fine and we can use the PR I raised which has all the checks passed to speed things up 👍🏻 No need to rebase your branch if you're going to close this PR

[thomas-riccardi]

closing in favor of #10855