Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce old digest functionality #95

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

NautiluX
Copy link
Contributor

@NautiluX NautiluX commented Jul 20, 2023

  • This digest function executes HEAD requests instead of querying the manifest
  • GET requests are ratelimited in some registries

Update to latest version wasn't possible due to rate limits in dependabot, see dependabot/dependabot-core#7578 (comment).

* This digest function executes HEAD requests instead of querying the manifest
* GET requests are ratelimited in some registries
@NautiluX
Copy link
Contributor Author

If this PR ends up being accepted, it would be awesome if you could push a tag again so we can upgrade dependabot to the latest version @deitch.

@NautiluX
Copy link
Contributor Author

@deitch what's your thinking about bringing back the old behavior in a new function? It would allow dependabot to update to a newer version and bump images on registry.access.redhat.com without caring about rate limits for the new GET requests introduced by 1.15.
On the other hand, people relying on the new functionality in 1.15 can still make use of that function.

@deitch
Copy link
Owner

deitch commented Jul 27, 2023

This just adds the new funcs, but doesn't change anything current?

@NautiluX
Copy link
Contributor Author

yes exactly. It would allow us to continue using the old functionality without breaking anyone relying on the new function.

@deitch deitch merged commit 768fdc8 into deitch:master Jul 27, 2023
12 checks passed
@yeikel
Copy link
Contributor

yeikel commented Sep 11, 2023

Although this is a new method, see this relevant discussion #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants