Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/k8s-resources] update hpa to latest v2 version #571

Merged
merged 4 commits into from
Apr 7, 2024
Merged

[stable/k8s-resources] update hpa to latest v2 version #571

merged 4 commits into from
Apr 7, 2024

Conversation

orkramer
Copy link
Contributor

@orkramer orkramer commented Mar 20, 2024 •
edited
Loading

Description

latest api version is v2 so I updated the hpa file.

In my case sync failed because of this error:
The Kubernetes API could not find version "v2beta1" of autoscaling/HorizontalPodAutoscaler for requested resource kube-system/k8s-resources-coredns-hpa. Version "v2" of autoscaling/HorizontalPodAutoscaler is installed on the destination cluster.

this PR will it.

Checklist

  • [ X] Title of the PR starts with chart name (e.g. [stable/mychartname])
  • [ X] I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@orkramer orkramer requested a review from a team as a code owner March 20, 2024 14:47
@orkramer orkramer changed the title [deliveryhero/k8s-resources] add option to override .apiVersion since its deprecated [stable/k8s-resources] add option to override .apiVersion since its deprecated Mar 20, 2024
@orkramer orkramer changed the title [stable/k8s-resources] add option to override .apiVersion since its deprecated [stable/k8s-resources] add option to override .apiVersion since it changed Mar 20, 2024
@orkramer orkramer changed the title [stable/k8s-resources] add option to override .apiVersion since it changed [stable/k8s-resources] update hpa to latest v2 version Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

max-rocket-internet
max-rocket-internet approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks @orkramer 💙

@max-rocket-internet max-rocket-internet merged commit fd9202c into deliveryhero:master Apr 7, 2024
5 checks passed
fekaiser pushed a commit to gastromatic/delivery-hero-helm-charts that referenced this pull request Oct 23, 2024
@orkramer @fekaiser
[stable/k8s-resources] update hpa to latest v2 version (deliveryhero#571
b76b923 
)

* add option to override .apiVersion since latest changed

* Update hpa.yaml

* Update Chart.yaml

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orkramer @max-rocket-internet