Skip to content

Commit

Permalink
Merge branch 'main' into usr/meggm/one-click
Browse files Browse the repository at this point in the history
  • Loading branch information
meggm authored Jan 29, 2025
2 parents 677d1a8 + 963bbac commit 786b3dd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Release CSI-Powerflex
# Invocable as a reusable workflow
# Can be manually triggered
on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
workflow_call:
workflow_dispatch:
inputs:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ build: dependencies

# Generates the docker container (but does not push)
docker: dependencies
make -f docker.mk build-base-image docker
make -f docker.mk docker

# Generates the docker container with no cache (but does not push)
docker-no-cache: dependencies
make -f docker.mk build-base-image docker-no-cache
make -f docker.mk docker-no-cache

# Pushes container to the repository
push: docker
Expand Down
13 changes: 4 additions & 9 deletions docker.mk
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,20 @@ IMAGETAG="v$(MAJOR).$(MINOR).$(PATCH)$(RELNOTE)"
endif


docker:
docker: download-csm-common
$(eval include csm-common.mk)
@echo "Base Images is set to: $(BASEIMAGE)"
@echo "Building: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"
$(BUILDER) build $(NOCACHE) -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" --target $(BUILDSTAGE) --build-arg GOPROXY --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .
$(BUILDER) build --pull $(NOCACHE) -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" --target $(BUILDSTAGE) --build-arg GOPROXY --build-arg BASEIMAGE=$(CSM_BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .

docker-no-cache:
docker-no-cache: download-csm-common
@echo "Building with --no-cache ..."
@make docker NOCACHE=--no-cache

push:
@echo "Pushing: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"
$(BUILDER) push "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"

build-base-image: download-csm-common
$(eval include csm-common.mk)
@echo "Building base image from $(DEFAULT_BASEIMAGE) and loading dependencies..."
./scripts/build_ubi_micro.sh $(DEFAULT_BASEIMAGE)
@echo "Base image build: SUCCESS"
$(eval BASEIMAGE=localhost/csipowerflex-ubimicro:latest)

download-csm-common:
curl -O -L https://raw.githubusercontent.com/dell/csm/main/config/csm-common.mk

0 comments on commit 786b3dd

Please sign in to comment.