Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating GetNodeLabels method #274

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Updating GetNodeLabels method #274

merged 2 commits into from
Jan 9, 2024

Conversation

suryagupta4
Copy link
Contributor

Description

Updating GetNodeLabels method to use spec.nodeName instead of hostname to fetch the node labels

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1086

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested the changes by installing the driver. The pods were up and running and the node labels were getting fetched correctly.

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suryagupta4 suryagupta4 merged commit d50d49e into main Jan 9, 2024
4 of 5 checks passed
@atye atye mentioned this pull request Jan 29, 2024
10 tasks
@AronAtDell AronAtDell deleted the node-labels branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants