Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume not expanded when using authorization's volumePrefix #412

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Jan 13, 2025

Description

Update code to account for the volmuePrefix added by the authorization module.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1663

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver with authorization and ran volume expansion test
    Screenshot 2025-01-14 163512

  • Installed driver on a kubernetes cluster and ran volume expansion test
    image

@AkshaySainiDell AkshaySainiDell changed the title [WIP] Fix volume not expanded when using authorization's volumePrefix Fix volume not expanded when using authorization's volumePrefix Jan 13, 2025
@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review January 13, 2025 13:07
@shaynafinocchiaro shaynafinocchiaro marked this pull request as draft January 14, 2025 20:08
@shaynafinocchiaro shaynafinocchiaro marked this pull request as ready for review January 14, 2025 21:32
service/node.go Show resolved Hide resolved
@alikdell alikdell merged commit 7d21235 into main Jan 14, 2025
6 checks passed
@alikdell alikdell deleted the bugfix-1663-node-expand-volume branch January 14, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants