Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update on simultaneous iSCSI and FC Protocol Support #1441

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Doc update on simultaneous iSCSI and FC Protocol Support #1441

merged 6 commits into from
Feb 5, 2025

Conversation

karthikk92
Copy link
Contributor

@karthikk92 karthikk92 commented Feb 3, 2025 •
edited by AkshaySainiDell
Loading

Description

Doc update on simultaneous iSCSI and FC Protocol Support for Unity

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1717

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@karthikk92 karthikk92 marked this pull request as ready for review February 3, 2025 10:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 21ac792. ± Comparison against base commit fe796fe.

♻️ This comment has been updated with latest results.

AkshaySainiDell
AkshaySainiDell approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rsedlock1958
rsedlock1958 reviewed Feb 3, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No grammatical edits are required.

rajkumar-palani
rajkumar-palani requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you respond to the comment? thank you.

content/v3/csidriver/troubleshooting/unity.md Show resolved Hide resolved
rajkumar-palani
rajkumar-palani approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suryagupta4 suryagupta4 merged commit c3ceefc into main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karthikk92 @rajkumar-palani @rsedlock1958 @AkshaySainiDell @suryagupta4