Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelinter scans for all charts #349

Closed
wants to merge 3 commits into from

Conversation

mdutka-dell
Copy link
Contributor

@mdutka-dell mdutka-dell commented Jan 10, 2024

Is this a new chart?

No

What this PR does / why we need it:

Which issue(s) is this PR associated with:

  • #Issue_Number

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

@cbartoszDell
Copy link
Contributor

Shouldn't we use one Kubelinter config for all charts?

@mdutka-dell
Copy link
Contributor Author

I group applications into three sections: csi, cosi and modules. Each section has its own KubeLinter configuration. KubeLinter supports 51 different checks, but I assume that some checks can be adequate for csi drivers and other for modules. We could also apply proposals:

  1. one kublinter config file for all charts
  2. config file per chart

@shaynafinocchiaro
Copy link
Contributor

Hi @mdutka-dell, it looks like this PR has gone stale. Is it alright to close it?

@mdutka-dell
Copy link
Contributor Author

Hi @mdutka-dell, it looks like this PR has gone stale. Is it alright to close it?

Well, we recently discussed how to test and provide best practices to our charts. It's worth to discuss the implementation of the kubelinter.

@shaynafinocchiaro
Copy link
Contributor

Closing PR since it has been inactive for some time. If we would like to implement kubelinter on our charts, we can reopen this PR.

@anandrajak1 anandrajak1 deleted the kubelinter-implementation branch October 17, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants