Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powermax endpoint update #570

Merged
merged 1 commit into from
Nov 22, 2024
Merged

powermax endpoint update #570

merged 1 commit into from
Nov 22, 2024

Conversation

nitesh3108
Copy link
Contributor

@nitesh3108 nitesh3108 commented Nov 22, 2024 •
edited
Loading

Is this a new chart?

No

What this PR does / why we need it:

This PR removes the duplicate entry of powermax endpoint and then powermax-array-config refers to endpoint from storageArrays section.

Which issue(s) is this PR associated with:

Special notes for your reviewer:

Tests performed

  • Validated Powermax Driver installation via helm-charts
  • Ran certify suit

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

prablr79
prablr79 approved these changes Nov 22, 2024
View reviewed changes
Copy link

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alikdell
Copy link
Contributor

Can we have some pointers on how this was tested?

shefali-malhotra
shefali-malhotra approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM . Please update the test results .

@shefali-malhotra shefali-malhotra merged commit 0eaee31 into release-v1.13.0 Nov 22, 2024
3 checks passed
@shefali-malhotra shefali-malhotra deleted the powermax-endpoint-remove branch November 22, 2024 14:01
rishabhatdell pushed a commit that referenced this pull request Jan 6, 2025
@nitesh3108 @rishabhatdell
powermax endpoint update (#570)
715d1f7
sharmilarama pushed a commit that referenced this pull request Jan 16, 2025
@santhoshatdell @KshitijaKakde
@nitesh3108 @dependabot @WilsonRadadia20 @sakshi-garg1 @shaynafinocchiaro @donatwork @alexemc @atye @AkshaySainiDell @ChristianAtDell @rishabhatdell
Release v1.13.0 (#617)
4d2d3ae 
* Remove mode: StandAlone from powermax reverseproxy config.yaml (#562)

* remove mode from pmax config.yaml

* remove mode from pmax config.yaml

* powermax endpoint update (#570)

* Bump dell/container-storage-modules/csm-authorization-sidecar (#565)

Bumps the csi-vxflexos group with 1 update in the /charts/csi-vxflexos directory: dell/container-storage-modules/csm-authorization-sidecar.


Updates `dell/container-storage-modules/csm-authorization-sidecar` from v1.12.0 to v2.0.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-sidecar
  dependency-type: direct:production
  dependency-group: csi-vxflexos
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dell/container-storage-modules/csm-authorization-sidecar (#566)

Bumps the container-storage-modules group with 1 update in the /installation-wizard/container-storage-modules directory: dell/container-storage-modules/csm-authorization-sidecar.


Updates `dell/container-storage-modules/csm-authorization-sidecar` from v1.12.0 to v2.0.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-sidecar
  dependency-type: direct:production
  dependency-group: container-storage-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dell/container-storage-modules/csm-authorization-sidecar (#567)

Bumps the karavi-observability group with 1 update in the /charts/karavi-observability directory: dell/container-storage-modules/csm-authorization-sidecar.


Updates `dell/container-storage-modules/csm-authorization-sidecar` from v1.12.0 to v2.0.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-sidecar
  dependency-type: direct:production
  dependency-group: karavi-observability
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dell/container-storage-modules/csm-authorization-sidecar (#568)

Bumps the csi-powermax group with 1 update in the /charts/csi-powermax directory: dell/container-storage-modules/csm-authorization-sidecar.


Updates `dell/container-storage-modules/csm-authorization-sidecar` from v1.12.0 to v2.0.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-sidecar
  dependency-type: direct:production
  dependency-group: csi-powermax
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dell/container-storage-modules/csm-authorization-sidecar (#564)

Bumps the csi-isilon group with 1 update in the /charts/csi-isilon directory: dell/container-storage-modules/csm-authorization-sidecar.


Updates `dell/container-storage-modules/csm-authorization-sidecar` from v1.12.0 to v2.0.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-sidecar
  dependency-type: direct:production
  dependency-group: csi-isilon
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Version bump up for CSM components (#572)

* Version bump up for CSM components

* Revert unecessary change

* Revert unecessary change

* Remove extra space

* Remove tab space

* Update Auth version

* Update the changes

* Update authorization sidecar image version

* Update csi-reverseproxy version

* Fix for linter check

* Update comments

* Update  comment

* Fixing broken links in Readme (#573) (#581)

* Adding fix for broken links in Readme

* Update README.md

* Bump sig-storage/csi-snapshotter (#580)

Bumps the csi-powerstore group with 1 update in the /charts/csi-powerstore directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: csi-powerstore
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sig-storage/csi-snapshotter (#579)

Bumps the csi-vxflexos group with 1 update in the /charts/csi-vxflexos directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: csi-vxflexos
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sig-storage/csi-snapshotter (#578)

Bumps the csi-unity group with 1 update in the /charts/csi-unity directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: csi-unity
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sig-storage/csi-snapshotter (#577)

Bumps the csi-isilon group with 1 update in the /charts/csi-isilon directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: csi-isilon
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sig-storage/csi-snapshotter (#576)

Bumps the container-storage-modules group with 1 update in the /installation-wizard/container-storage-modules directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: container-storage-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sig-storage/csi-snapshotter (#575)

Bumps the csi-powermax group with 1 update in the /charts/csi-powermax directory: sig-storage/csi-snapshotter.


Updates `sig-storage/csi-snapshotter` from v8.1.0 to v8.2.0

---
updated-dependencies:
- dependency-name: sig-storage/csi-snapshotter
  dependency-type: direct:production
  dependency-group: csi-powermax
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/create-github-app-token in the github-actions group (#585)

Bumps the github-actions group with 1 update: [actions/create-github-app-token](https://github.com/actions/create-github-app-token).


Updates `actions/create-github-app-token` from 1.11.0 to 1.11.1
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Commits](actions/create-github-app-token@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: actions/create-github-app-token
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the csm-authorization group across 2 directories with 5 updates (#569)

* Bump the csm-authorization group across 2 directories with 5 updates

Bumps the csm-authorization group with 5 updates in the /charts/csm-authorization directory:

| Package | From | To |
| --- | --- | --- |
| dell/container-storage-modules/csm-authorization-proxy | `v1.12.0` | `v2.0.0` |
| dell/container-storage-modules/csm-authorization-tenant | `v1.12.0` | `v2.0.0` |
| dell/container-storage-modules/csm-authorization-role | `v1.12.0` | `v2.0.0` |
| dell/container-storage-modules/csm-authorization-storage | `v1.12.0` | `v2.0.0` |
| openpolicyagent/kube-mgmt | `8.5.10` | `8.5.11` |

Bumps the csm-authorization group with 1 update in the /charts/csm-authorization-v2.0 directory: openpolicyagent/kube-mgmt.


Updates `dell/container-storage-modules/csm-authorization-proxy` from v1.12.0 to v2.0.0

Updates `dell/container-storage-modules/csm-authorization-tenant` from v1.12.0 to v2.0.0

Updates `dell/container-storage-modules/csm-authorization-role` from v1.12.0 to v2.0.0

Updates `dell/container-storage-modules/csm-authorization-storage` from v1.12.0 to v2.0.0

Updates `openpolicyagent/kube-mgmt` from 8.5.10 to 8.5.11

Updates `openpolicyagent/kube-mgmt` from 8.5.10 to 8.5.11

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csm-authorization-proxy
  dependency-type: direct:production
  dependency-group: csm-authorization
- dependency-name: dell/container-storage-modules/csm-authorization-tenant
  dependency-type: direct:production
  dependency-group: csm-authorization
- dependency-name: dell/container-storage-modules/csm-authorization-role
  dependency-type: direct:production
  dependency-group: csm-authorization
- dependency-name: dell/container-storage-modules/csm-authorization-storage
  dependency-type: direct:production
  dependency-group: csm-authorization
- dependency-name: openpolicyagent/kube-mgmt
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: csm-authorization
- dependency-name: openpolicyagent/kube-mgmt
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: csm-authorization
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update values.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com>

* Bump the csm-authorization group across 2 directories with 5 updates (#582)

* Removed a redundant volume mount from the pmax driver container. (#586) (#590)

Co-authored-by: Babiychuk <32580729+alexemc@users.noreply.github.com>

* use OPA 0.70.0 (#592)

* change clusterrole name to not interfere with the clusterrole view in kubernetes (#593)

* Update CSI-PowerMax to mount reverse proxy TLS secret within driver container (#588)

* Mount tls secret into driver container

* Update node.yaml

* Add IP to SAN

* Bump the container-storage-modules group across 1 directory with 4 updates (#605)

* Bump the csi-vxflexos group across 1 directory with 4 updates (#603)

* Bump the csi-isilon group across 1 directory with 4 updates (#602)

* Bump the csi-powerstore group across 1 directory with 4 updates (#601)

* Bump the csi-unity group across 1 directory with 4 updates (#604)

* Bump the csi-powermax group across 1 directory with 4 updates (#607)

* updated SDC images to quay (#609)

* Release v1.13.0 Rebase (#611)

* Fixing broken links in Readme (#573)

* Adding fix for broken links in Readme

* Update README.md

* Modifiable values consistent across drivers (#583)

* made values.yaml consistent across drivers

* fixed review comments

* fixed new review comments

* Removed a redundant volume mount from the pmax driver container. (#586)

Co-authored-by: Babiychuk <32580729+alexemc@users.noreply.github.com>

---------

Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com>
Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: Babiychuk <32580729+alexemc@users.noreply.github.com>

* Bump the container-storage-modules group across 1 directory with 3 updates (#612)

* Bump the container-storage-modules group across 1 directory with 3 updates

Bumps the container-storage-modules group with 3 updates in the /installation-wizard/container-storage-modules directory: dell/container-storage-modules/csi-volumegroup-snapshotter, dell/container-storage-modules/dell-csi-migrator and dell/container-storage-modules/dell-csi-node-rescanner.


Updates `dell/container-storage-modules/csi-volumegroup-snapshotter` from v1.8.0 to v1.8.1

Updates `dell/container-storage-modules/dell-csi-migrator` from v1.6.0 to v1.7.0

Updates `dell/container-storage-modules/dell-csi-node-rescanner` from v1.5.0 to v1.6.0

---
updated-dependencies:
- dependency-name: dell/container-storage-modules/csi-volumegroup-snapshotter
  dependency-type: direct:production
  dependency-group: container-storage-modules
- dependency-name: dell/container-storage-modules/dell-csi-migrator
  dependency-type: direct:production
  dependency-group: container-storage-modules
- dependency-name: dell/container-storage-modules/dell-csi-node-rescanner
  dependency-type: direct:production
  dependency-group: container-storage-modules
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updated versions at remaining places

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: santhoshatdell <Santhosh.Lakshmanan@dell.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Nitesh-Rewatkar <90749010+nitesh3108@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wilson Radadia <159131702+WilsonRadadia20@users.noreply.github.com>
Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: Babiychuk <32580729+alexemc@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: ChristianAtDell <110482953+ChristianAtDell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@prablr79 prablr79 prablr79 approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@chaganti-rajitha chaganti-rajitha Awaiting requested review from chaganti-rajitha chaganti-rajitha is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitesh3108 @alikdell @prablr79 @shefali-malhotra