Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Consistency Typo and Checkmarx #241

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

doriac11
Copy link
Contributor

@doriac11 doriac11 commented Nov 8, 2024

Description

  • Fix Typo
  • Fix Checkmarxs issue with deep equal

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT

- Fix Typo
- Fix Checkmarxs issue
@doriac11 doriac11 force-pushed the pub/fix-consistency-typo branch from 587747a to 043b2de Compare November 8, 2024 14:14
@doriac11
Copy link
Contributor Author

doriac11 commented Nov 8, 2024

run e2e test

@doriac11 doriac11 merged commit edaf5be into main Nov 8, 2024
7 checks passed
@doriac11 doriac11 deleted the pub/fix-consistency-typo branch November 8, 2024 14:31
@doriac11 doriac11 restored the pub/fix-consistency-typo branch November 8, 2024 14:31
@doriac11 doriac11 deleted the pub/fix-consistency-typo branch November 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants