Version check for NVMe host #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baoy1
requested review from
shenda1,
AnikaAgiwal2711,
gokul-srivathsan,
Krunal-Thakkar,
Krishnan-Priyanshu,
rounak-adhikary and
a team
as code owners
baoy1
force-pushed
the
usr/baoy1/nvme_version_check
branch
2 times, most recently
from
90104bb to
ce6300c
Compare
doriac11
approved these changes
Nov 13, 2024
forrestxia
approved these changes
Nov 14, 2024
|
run e2e test |
1 similar comment
|
run e2e test |
baoy1
force-pushed
the
usr/baoy1/nvme_version_check
branch
from
ce6300c to
fe2f94b
Compare
|
run e2e test NvmeHost,NvmeTarget |
Updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported Fix empty NVMe host name Empty host name should not be used for create and update.
baoy1
force-pushed
the
usr/baoy1/nvme_version_check
branch
from
fe2f94b to
e4265e7
Compare
|
run e2e test NvmeHost,NvmeTarget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The APIs for updating the NVMe host will throw error in PowerFlex 4.5.
The commit adds version check for updating and alert message:
Updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported.
md and example are updated accordingly.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
PowerFlex 4.5