Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FaultSet Datasource Filter #259

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

doriac11
Copy link
Contributor

@doriac11 doriac11 commented Dec 6, 2024

Description

  • Update to new filter paradigm for fault set

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • AT
  • UT

Coverage Report

image

@doriac11 doriac11 force-pushed the pub/powerflex-fault-set-filter branch from 27b614c to cc729f7 Compare December 6, 2024 15:01
@doriac11 doriac11 force-pushed the pub/powerflex-fault-set-filter branch from cc729f7 to 5386f31 Compare December 6, 2024 15:43
@doriac11 doriac11 merged commit c5efd03 into filter-feature-branch Dec 6, 2024
6 checks passed
@doriac11 doriac11 deleted the pub/powerflex-fault-set-filter branch December 6, 2024 15:45
doriac11 added a commit that referenced this pull request Jan 17, 2025
* Update Volume Filter (#251)

* Powerflex Storage Pool Filter Update (#252)

- Storage Group Filter Update

* Update vTree Datasource Filter (#253)

* Updated filter on comp report (#255)

* Update FaultSet Datasource Filter (#259)

* SDC Datasource Filter (#257)

* Updated filters on Snapshot policy (#260)

* Updated sds filter (#261)

* Firmware Repository Filter Update (#262)

* Updated node filters (#263)

* Protection Domain Filter Update (#264)

* Device Filter Update (#265)

* Updated resource group filters (#267)

* Updated Template filters (#266)

* Fixed bug where code panics at filtering omitted values (#268)

* Fixed bug where code panics at filtering omitted values (#269)

removed fields from node

* removed lifecycle_mode_reasons (#270)

* Powerflex Code Coverage Increase (#272)

- Increase Code Coverage to above 80%

* Added Regex Filter to datasource filtering (#273)

* Remove Unused variables from tests

* Fix G115 (CWE-190): integer overflow conversion int64

---------

Co-authored-by: Connor Doria <128822122+doriac11@users.noreply.github.com>
Co-authored-by: cdoria <connor.doria@dell.com>
Co-authored-by: Yiming Bao <yiming.bao@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants