Skip to content

Commit

Permalink
[Spark] Followup to #3633: update some comments to checkAddFileWithDe…
Browse files Browse the repository at this point in the history
…letionVectorStatsAreNotTightBounds (#3641)

Post merge review followup: update and fix some comments.

Co-authored-by: Julek Sompolski <Juliusz Sompolski>
  • Loading branch information
juliuszsompolski committed Sep 19, 2024
1 parent 408b894 commit dcaf833
Showing 1 changed file with 11 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ object DeltaOperations {
}
override def changesData: Boolean = true

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
// DVs can be introduced by the replaceWhere operation.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

Expand Down Expand Up @@ -200,7 +200,7 @@ object DeltaOperations {
override val operationMetrics: Set[String] = DeltaOperationMetrics.STREAMING_UPDATE
override def changesData: Boolean = true

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand All @@ -226,7 +226,7 @@ object DeltaOperations {
}
override def changesData: Boolean = true

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand All @@ -237,7 +237,7 @@ object DeltaOperations {
override val operationMetrics: Set[String] = DeltaOperationMetrics.TRUNCATE
override def changesData: Boolean = true

// This operation shouldn't be introducing AddFile actions with DVs and non-tight bounds stats.
// This operation shouldn't be introducing AddFile actions at all. This check should be trivial.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand Down Expand Up @@ -434,6 +434,8 @@ object DeltaOperations {
override val parameters: Map[String, Any] = Map("properties" -> JsonUtils.toJson(properties))

// This operation shouldn't be introducing AddFile actions at all. This check should be trivial.
// Note: This operation may trigger additional actions and additional commits. For example
// RowTrackingBackfill. These are separate transactions, and this check is performed separately.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand All @@ -460,6 +462,8 @@ object DeltaOperations {
"truncateHistory" -> truncateHistory)

// This operation shouldn't be introducing AddFile actions at all. This check should be trivial.
// Note: this operation may trigger additional actions and additional commits. These would be
// separate transactions, and this check is performed separately.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand Down Expand Up @@ -697,7 +701,7 @@ object DeltaOperations {

override val operationMetrics: Set[String] = DeltaOperationMetrics.OPTIMIZE

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand Down Expand Up @@ -771,7 +775,7 @@ object DeltaOperations {

override val operationMetrics: Set[String] = DeltaOperationMetrics.OPTIMIZE

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand Down Expand Up @@ -854,7 +858,7 @@ object DeltaOperations {
OP_UPGRADE_UNIFORM_BY_REORG) {
override val parameters: Map[String, Any] = Map("properties" -> JsonUtils.toJson(properties))

// This operation shouldn't be introducing AddFile actions with DVs and non tight bounds stats.
// This operation shouldn't be introducing AddFile actions with DVs and tight bounds stats.
override def checkAddFileWithDeletionVectorStatsAreNotTightBounds: Boolean = true

override val isInPlaceFileMetadataUpdate: Option[Boolean] = Some(false)
Expand Down

0 comments on commit dcaf833

Please sign in to comment.