Improve DV path canonicalization #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsk-db Could you take a look at this PR? |
larsk-db
approved these changes
Jun 13, 2023
core/src/main/scala/org/apache/spark/sql/delta/commands/DeleteWithDeletionVectorsHelper.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/commands/DeleteWithDeletionVectorsHelper.scala
Outdated
Show resolved
Hide resolved
vkorukanti
approved these changes
Jun 16, 2023
vkorukanti
pushed a commit
that referenced
this pull request
Jun 20, 2023
## Description This PR improves the FILE_PATH canonicalization logic by avoiding calling expensive `Path.toUri.toString` calls for each row in a table. Canonicalized paths are now cached and the UDF just needs to look it up. Future improvement is possible for handling huge logs: build `canonicalizedPathMap` in a distributed way. Related PR target the 2.4 branch: #1829. Existing tests. Closes #1836 Signed-off-by: Paddy Xu <xupaddy@gmail.com> GitOrigin-RevId: c4810852f9136c36ec21f3519620ca26ed12bb04
| // Build two maps, using Path or String as keys. The one with String keys is used in UDF. | ||
| val canonicalizedPathMap = buildCanonicalizedPathMap(txn.deltaLog, candidateFiles) | ||
| val canonicalizedPathStringMap = | ||
| canonicalizedPathMap.map { case (k, v) => k.toString -> v } |
There was a problem hiding this comment.
Why have this second pass, for a single-callsite helper method? Can it just return a string-string map directly, since that's what we ultimately broadcast?
There was a problem hiding this comment.
Thanks for the comment! I addressed your comment in a later PR #1770.
|
Closed in favor of #1770. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the FILE_PATH canonicalization logic by avoiding calling expensive
Path.toUri.toStringcalls for each row in a table. Canonicalized paths are now cached and the UDF just needs to look it up.Future improvement is possible for handling huge logs: build
canonicalizedPathMapin a distributed way.How was this patch tested?
Existing tests.