Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial flink test fix #1848

Closed
wants to merge 1 commit into from

Conversation

scottsand-db
Copy link
Collaborator

getDeltaCheckpointFiles should just explicitly filter for file names that end with .checkpoint.parquet. We don't want to accidentally read .crc files and return true.

@scottsand-db scottsand-db requested a review from tdas June 20, 2023 22:28
@scottsand-db scottsand-db self-assigned this Jun 20, 2023
@tdas
Copy link
Contributor

tdas commented Jun 20, 2023

Oh thank you! This is what was failing in my PR (#1845) trying to make the connectors tests run

@tdas
Copy link
Contributor

tdas commented Jun 20, 2023

Since this tests none of these tests actually are going to test this change.. I am going to just merge this PR

@tdas tdas closed this in e1a84d2 Jun 20, 2023
Copy link
Contributor

@tdas tdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants