Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Add Delta Connect Merge Server and Scala Client #3671

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

longvu-db
Copy link
Contributor

@longvu-db longvu-db commented Sep 11, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Add support for merge for Delta Connect Server and Scala Client.

The previous PR got reverted since Delta Spark Master testing was broken and Delta Connect's DeltaMergeBuilder was forgotten to be added.

The isSchemaEvolution API was also supposed to be added for Delta Connect in that PR to have feature parity with Delta Classic Scala/Python Client.

How was this patch tested?

Added UTs, tested locally with a checkpoint of Spark Master, the point of time before the Spark commits that broke Delta Spark Master tests were introduced.

Does this PR introduce any user-facing changes?

This PR allows users to do MERGE on Delta Connect (Delta over Spark Connect), so anything that users are able to do with MERGE normally should also be possible with Spark Connect.

longvu-db and others added 6 commits September 11, 2024 19:07
## Description
Add support for `merge` for Delta Connect Server and Scala Client.

## How was this patch tested?
Added UTs.

## Does this PR introduce _any_ user-facing changes?
No.
Copy link
Contributor

@xupefei xupefei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants