Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark] Fix delta-spark test log4j #3700

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[Spark] Fix delta-spark test log4j #3700

merged 1 commit into from
Sep 20, 2024

Conversation

scottsand-db
Copy link
Collaborator

@scottsand-db scottsand-db commented Sep 20, 2024 •
edited
Loading

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

#3146 added support for spark master structured logging, but broke the test logging for delta-spark against spark 3.5. This PR fixes that.

The broken logging looked like this (https://github.com/delta-io/delta/actions/runs/10856009436/job/30129811815):

ERROR StatusConsoleListener Unable to locate plugin type for JsonTemplateLayout
ERROR StatusConsoleListener Unable to locate plugin for JsonTemplateLayout
ERROR StatusConsoleListener Could not create plugin of type class org.apache.logging.log4j.core.appender.FileAppender for element File: java.lang.NullPointerException
 java.lang.NullPointerException
	at org.apache.logging.log4j.core.config.plugins.visitors.PluginElementVisitor.findNamedNode(PluginElementVisitor.java:104)

How was this patch tested?

GitHub CI tests.

Does this PR introduce any user-facing changes?

No.

raveeram-db
raveeram-db approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@raveeram-db raveeram-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zedtang
zedtang approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@zedtang zedtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing this

@scottsand-db scottsand-db merged commit cddde68 into delta-io:master Sep 20, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raveeram-db raveeram-db raveeram-db approved these changes

@zedtang zedtang zedtang approved these changes

@vkorukanti vkorukanti Awaiting requested review from vkorukanti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottsand-db @zedtang @raveeram-db