Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kernel] [CC Refactor] Make Metadata implement AbstractMetadata; fix Metadata partition col APIs #3834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Kernel] [CC Refactor] Make Metadata implement AbstractMetadata; fix Metadata partition col APIs #3834

wants to merge 2 commits into from

Conversation

scottsand-db
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

  • Make Metadata implement AbstractMetadata
  • Update kernel's AbstractMetadata to align it with delta-storage's AbstractMetadata (storage uses Long for createdTime, kerenel used Optional).
  • Update kernel's AbstractMetadata to all @Nulalble annotations to make it clear the expected return values.
  • Consolidate Metadata's getPartitionColumn APIs (there were two APIs, with different return types and different case-sensitivities; now there's only 1 API)

How was this patch tested?

Just a refactor. Existing UTs.

Does this PR introduce any user-facing changes?

No.

@scottsand-db scottsand-db self-assigned this Oct 30, 2024
@scottsand-db scottsand-db mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkorukanti vkorukanti Awaiting requested review from vkorukanti

@allisonport-db allisonport-db Awaiting requested review from allisonport-db

@dhruvarya-db dhruvarya-db Awaiting requested review from dhruvarya-db

@sumeet-db sumeet-db Awaiting requested review from sumeet-db

Assignees

@scottsand-db scottsand-db

Labels
kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scottsand-db