Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt out of webview metrics collection #3413

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Opt out of webview metrics collection #3413

merged 1 commit into from
Nov 11, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Nov 5, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s
r10s approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! even though data seems to be uploaded only if the user consents, it seems good to have that disabled as general precaution and stance

@link2xt
Copy link
Contributor Author

link2xt commented Nov 5, 2024

Where exactly does the user consent I wonder, don't remember being asked about it on Android.

@r10s
Copy link
Member

r10s commented Nov 5, 2024 •
edited
Loading

i think, it is this one (seen on android7, motog at "System Settings / Google"):

pretty sure, they ask before, showing a 150 pages document where this is somewhere written.

next time, if someone complains for too-high-battery-usage, we will be blamed for having that disabled :)

@link2xt
Copy link
Contributor Author

link2xt commented Nov 5, 2024

So i was not asked because i don't have "Google services" on my phone :)

@adbenitez adbenitez added the enhancement actually in development, user visible enhancement label Nov 9, 2024
@link2xt link2xt merged commit 6e135e0 into main Nov 11, 2024
2 checks passed
@link2xt link2xt deleted the link2xt/webview-metrics-opt-out branch November 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbenitez adbenitez adbenitez approved these changes

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@link2xt @r10s @adbenitez