-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api!(deltachat-jsonrpc): use kind
as a tag for all union types
#4602
Conversation
bff0aef
to
188d21f
Compare
90331c7
to
a883c2b
Compare
I have tried to change
It results in this OpenRPC specification:
Generated TypeScript type is this:
I am going to change the type to have no anonymous fields so this does not happen, but also reported a bug at dbeckwith/rust-typescript-type-def#24 |
2febab8
to
454d097
Compare
454d097
to
e12044e
Compare
31e838a
to
88d0087
Compare
There is a There are some weird types remaining, all involving maps, for example:
In
The problem is that the key of the map is nowhere to be found, it's a bug in Once this is fixed the parser is ready and the remaining part is generating the code to serialize/deserialize arguments and results. I opened an upstream issue at GREsau/schemars#235 |
kind
as a tag for all union types7650d19
to
e12044e
Compare
kind
as a tag for all union types
I have merged this change as no other type changes are needed. |
Closes #4601