Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try only the full email address if username is unspecified #5826

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Aug 1, 2024

Previously Delta Chat tried to use local part of email address as well. This configuration is very uncommon,
but trying it doubled the time of configuration try in the worst case, e.g. when the password is typed in incorrectly.

Previously Delta Chat tried to use local part of email address as well.
This configuration is very uncommon,
but trying it doubled the time of configuration try
in the worst case, e.g. when the password is typed in incorrectly.
@link2xt
Copy link
Collaborator Author

link2xt commented Aug 1, 2024

I have looked at the provider database, it seems this configuration is very uncommon. Providers in the provider database that I tried (riseup and disroot) actually support both usernames. In case of riseup full email address is actually the "official" way to configure it: deltachat/provider-db#298

Currently trying both usernames is not a serious problem except for doubling the time if user has mistyped the password, but I plan to work on "automatic reconfiguration" using #5807 once #5808 is merged and having twice as much candidates in the list is not nice. If both types of login are supported then these candidates are redundant and if only one of them is supported we are going to constantly annoy the server with failed login attempts on every network hiccup. In the rare case of email address not being accepted as the login and provider has no autoconfig XML or provider database configuration, user can specify only the username in advanced settings and still have automatic reconfiguration working.

@link2xt link2xt self-assigned this Aug 1, 2024
Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user can specify only the username in advanced settings and still have automatic reconfiguration working.

+1, this is much better than trying to guess the username.

@link2xt link2xt merged commit 21be850 into main Aug 1, 2024
37 checks passed
@link2xt link2xt deleted the link2xt/autoconfig-no-localpart branch August 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants