Add Labelled hashtag #69
Conversation
|
don't forget to add the specification for the new element to |
Do we need labelled hashtags in desktop and markdown sets, too? |
| @@ -23,6 +23,7 @@ | |||
| - [Delimited Email addresses: `<hello@delta.chat>`](#delimited-email-addresses) | |||
| - [Delimited Links: `<http://example.org>`](#delimited-links) | |||
| - [Labeled Links: `[Name](url)`](#labled-links) | |||
| - [Labeled hashtags: `[Tag][#tag]`](#labeled-tags) | |||
There was a problem hiding this comment.
do we also want to have this in the desktop set?
| ### Labelled hashtags | ||
|
|
||
| The idea is to have hashtags but labelled with an alternative text. This feature is very unique and less seen in other IMs. | ||
|
|
There was a problem hiding this comment.
please also make an example and spec to define how it looks like:
[Label](#tag)
and say what it does: "clicking on it opens the search with that hashtag like for the normal hashtag but looks like a link", or sth along those lines
src/main.rs
Outdated
There was a problem hiding this comment.
file change seems unrelated, I guess we should turn this into a full cli-app at some point where you can select the mode via argument. (maybe with the clap library)
| if let Ok((i, elm)) = labelled_tag(input) { | ||
| Ok((i, elm)) |
There was a problem hiding this comment.
the fabled tag should only be in the markdown set and maybe also in the desktop set, but not in the text set.
rule of thumb: Things in the text set are kept at the original, just linkified, but text is still the same
There was a problem hiding this comment.
You sure? hashtag is already in text elements.
There was a problem hiding this comment.
yes, labeled link and labeled hashtag both modify the text, while text elements only make the text clickable
| take_while1(|c| !matches!(c, '[' | ']')), | ||
| char(']'), | ||
| )(input)?; | ||
| let elements: Vec<Element> = parse_only_text(label); |
There was a problem hiding this comment.
No description provided.