Skip to content

Comments

Dmb master api path update#57

Open
donovanbray wants to merge 9 commits intomasterfrom
dmb-master-api-path-update
Open

Dmb master api path update#57
donovanbray wants to merge 9 commits intomasterfrom
dmb-master-api-path-update

Conversation

@donovanbray
Copy link
Contributor

before navigation update:
before_navigation

after navigation update

removed distinction between core and additional calls and put them in alpha order

after_navigation

before paths
before_paths

after paths

Made them consistent from the root, this is just one example.

after_paths

before next_page
before_next_page

after next_page

next_page isn't presented on empty sets nor where there is NOT a next page available

after_next_page

before kramdown format update
before_kramdown_formatting

after kramdown format update

indenting was being ignored

after_kramdown_formatting

@donovanbray
Copy link
Contributor Author

Would like sign-off from at least:

@LukeHammond @hunpin @RealNobody

@RealNobody
Copy link

What I read through, looked fine to me.

@subramantr
Copy link
Contributor

Keeping in alphabetical order is good. I don't know why we had distinction between core and additional calls earlier.

@RealNobody
Copy link

👍

@LukeHammond
Copy link
Contributor

very nice 👍

@subramantr
Copy link
Contributor

My question is just to know about background. I don't see anything that prevents this from getting merged. 👍

@donovanbray
Copy link
Contributor Author

background was simply I was trying to do a proof of concept using our API for midatalantic-exports, and I found our documentation confusing, and wrong in some places. So I set about correcting it.

POC: https://github.com/demandchain/midatlantic-exports/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants