Open
Conversation
added 9 commits
April 6, 2015 16:50
Contributor
Author
|
Would like sign-off from at least: |
|
What I read through, looked fine to me. |
Contributor
|
Keeping in alphabetical order is good. I don't know why we had distinction between core and additional calls earlier. |
|
👍 |
Contributor
|
very nice 👍 |
Contributor
|
My question is just to know about background. I don't see anything that prevents this from getting merged. 👍 |
Contributor
Author
|
background was simply I was trying to do a proof of concept using our API for midatalantic-exports, and I found our documentation confusing, and wrong in some places. So I set about correcting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before navigation update:

after navigation update
removed distinction between core and additional calls and put them in alpha order
before paths

after paths
Made them consistent from the root, this is just one example.
before next_page

after next_page
next_page isn't presented on empty sets nor where there is NOT a next page available
before kramdown format update

after kramdown format update
indenting was being ignored