Open
Conversation
Khmelov
approved these changes
Oct 23, 2025
Khmelov
left a comment
Khmelov
left a comment
There was a problem hiding this comment.
Приложение хорошо структурировано, и чувствуется некоторые опыт в разработке. Поставил максимальную оценку а
| public class TwistEncryptor { | ||
| public static void main(String[] args) { | ||
| View view = new ConsoleView(); | ||
| Application application = new Application(view); |
| public abstract class Alphabet { | ||
| protected final int length; | ||
| protected final char[] symbols; | ||
| protected final Map<Character, Integer> map; |
There was a problem hiding this comment.
Ну наконец-то кто-то догадался использовать карту. Лайк
| " " | ||
| ).toCharArray()); | ||
|
|
||
| dictionary = new HashSet<>(List.of("the", "and", "is", "in", "to", "of", "it", "that", "was", "he")); |
There was a problem hiding this comment.
Если этот словарь никогда не поменяется то лучше сделать его полем и инициализировать там однажды
| ).toCharArray() | ||
| ); | ||
|
|
||
| dictionary = new HashSet<>(List.of( |
| @@ -0,0 +1,25 @@ | |||
| package com.javarush.aleinik.twistencryptor.entity; | |||
|
|
|||
| public class KeyCandidate { | |||
There was a problem hiding this comment.
Чувствуется что это не начинающий джава программист
| private final Path path; | ||
| private int key; | ||
|
|
||
| public UserParameters(Language language, Mode mode, int key, Path path) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.