Open
Conversation
Khmelov
approved these changes
Oct 23, 2025
Khmelov
left a comment
Khmelov
left a comment
There was a problem hiding this comment.
Написано интригующая и современно, но почему не разбито на пакеты загадка, насколько я понял реализованный две функции что не очень хорошо, но с учётом на качества кода поставил оценку б
| import java.util.Map; | ||
|
|
||
| @FunctionalInterface | ||
| public interface Alphabet extends Parser, Mapper { |
There was a problem hiding this comment.
Ух ты мы вроде это ещё не проходили к началу первого проекта
| @@ -0,0 +1,7 @@ | |||
| package ru.javarush.lim.cryptoanalizer.util.alphabet; | |||
|
|
|||
| public class AlphabetConfig { | |||
There was a problem hiding this comment.
Интересно а почему файлы находятся в ресурсах
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
|
|
||
| public record AlphabetData(Map<Character, Integer> direct, Map<Integer, Character> reverse, String symbols) { |
|
|
||
| public class CaesarFileRunner { | ||
|
|
||
| private static final Logger logger = LoggerSingleton.getInstance(); |
| import ru.javarush.lim.cryptoanalizer.util.logger.LoggerSingleton; | ||
|
|
||
| public class ConsoleView { | ||
| private final Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
Сканер можно Injected через конструктор
| private LoggerStyle() { | ||
| } | ||
|
|
||
| public enum TextColor { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.