Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf #88

Merged
merged 28 commits into from
Dec 3, 2020
Merged

Perf #88

merged 28 commits into from
Dec 3, 2020

Conversation

phildong
Copy link
Member

merge performance branch

phildong and others added 27 commits October 21, 2020 22:45
change `open_minian` and `save_minian` to facilitate storing intermediate variables.
add on-disk rechunking factionality through `rechunker`
optimize the function to be more friendly to dask scheduler.
limit depth of parallelization to avoid long computing graph construction.
avoid excessive rechunking during seeds operations.
use sparse matrices for merging operations and initial spatial footprints.
optmize (throttle) operations to be friendly to small memory constraint.
NOTE pyfftw doesn't seem to be multi-threading friendly.
optimize temporal and spatial update to use sparse matrix whenever possible.
use intermediate variables to allow for smaller memory constraint.
throttle operations to be friendly to memory constraint.
add options to warm start for temporal update.
concurrent update default to disabled.
add size threshold for spatial update.
pyav doesn't seem to be friendly to dask distributed scheduler.
this should get around OS file handle limit.
should reduce the repeated computation of AtC during generation of final video.
avoiding regrid and replace with dynamic map when necessary.
this should eliminate the need to restart the kernel during pipeline.
Now all of them are specified as a fraction of sampling rate.
…sts and many more fixes and updates (no test fixtures) (#75)

Co-authored-by: phildong <35715936+phildong@users.noreply.github.com>
Co-authored-by: paolo <paolo.bazzigaluppi@gmail.com>
Co-authored-by: phild <zhe.dong@icahn.mssm.edu>
Co-authored-by: Denise Cai Laboratory <47047748+DeniseCaiLab@users.noreply.github.com>
Co-authored-by: William Mau <wmau@bu.edu>
Co-authored-by: Matthias Klumpp <matthias@tenstral.net>
Co-authored-by: Cloud User <ec2-user@ip-172-31-27-133.us-west-2.compute.internal>
Co-authored-by: Jesus M <yeshuarmartinez@gmail.com>
…sh within the 50 minutes time limit of Travis
@zsinnema
Copy link
Collaborator

@phildong can you please run black to fix code style errors? this will fix the travis build
btw I pushed a commit to disable running the tests and upload the coverage in the travis build. the reason for this is that the 50 minutes limit for travis build is not enough to finish running all tests
you can run the tests on your local machine and upload the coverage manually

* chore: added github actions workflow file
* chore: reformated with black 19.10b0
* chore: pinned black to version conda-forge 19.10b0
* chore: install ffmpeg for github actions
* chore: github actions update ubuntu
* fix: added test movies *.mp4 to test movie fixture
@phildong phildong merged commit 0c6c161 into dev Dec 3, 2020
@phildong phildong deleted the perf branch December 3, 2020 20:19
@phildong phildong restored the perf branch December 3, 2020 20:21
phildong added a commit that referenced this pull request Dec 7, 2020
This reverts commit 0c6c161.
@phildong phildong mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants