-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change `open_minian` and `save_minian` to facilitate storing intermediate variables. add on-disk rechunking factionality through `rechunker`
optimize the function to be more friendly to dask scheduler. limit depth of parallelization to avoid long computing graph construction.
avoid excessive rechunking during seeds operations. use sparse matrices for merging operations and initial spatial footprints. optmize (throttle) operations to be friendly to small memory constraint.
NOTE pyfftw doesn't seem to be multi-threading friendly.
optimize temporal and spatial update to use sparse matrix whenever possible. use intermediate variables to allow for smaller memory constraint. throttle operations to be friendly to memory constraint. add options to warm start for temporal update. concurrent update default to disabled. add size threshold for spatial update.
pyav doesn't seem to be friendly to dask distributed scheduler.
this should get around OS file handle limit.
should reduce the repeated computation of AtC during generation of final video.
avoiding regrid and replace with dynamic map when necessary. this should eliminate the need to restart the kernel during pipeline.
Now all of them are specified as a fraction of sampling rate.
…sts and many more fixes and updates (no test fixtures) (#75) Co-authored-by: phildong <35715936+phildong@users.noreply.github.com> Co-authored-by: paolo <paolo.bazzigaluppi@gmail.com> Co-authored-by: phild <zhe.dong@icahn.mssm.edu> Co-authored-by: Denise Cai Laboratory <47047748+DeniseCaiLab@users.noreply.github.com> Co-authored-by: William Mau <wmau@bu.edu> Co-authored-by: Matthias Klumpp <matthias@tenstral.net> Co-authored-by: Cloud User <ec2-user@ip-172-31-27-133.us-west-2.compute.internal> Co-authored-by: Jesus M <yeshuarmartinez@gmail.com>
…added cross reg notebook to userguide (#86)
…sh within the 50 minutes time limit of Travis
@phildong can you please run black to fix code style errors? this will fix the travis build |
* chore: added github actions workflow file * chore: reformated with black 19.10b0 * chore: pinned black to version conda-forge 19.10b0 * chore: install ffmpeg for github actions * chore: github actions update ubuntu * fix: added test movies *.mp4 to test movie fixture
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge performance branch