Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in the forward part #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coffeedjimmy
Copy link

In the tutorial notebook, I found one curious point.

In the forward propagation, s[-1] is added as the additional operation. However, in the declaration of s array, it is defined as (T+1, hidden_dim) shape.

I know this is very minor point but when I study RNN with your post I took some time why this is (T+1, hidden_dim) instead of (T, hidden_dim). Due to this, I send this PR.

Thank you for your posting again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant