feat(net): allow unix sockets on windows #10377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Unix(net_unix::UnixAddr), | ||
| #[cfg(unix)] | ||
| UnixPacket(net_unix::UnixAddr), |
There was a problem hiding this comment.
Unixpacket is not supported on Windows.
There was a problem hiding this comment.
Thanks, I suspected that might not be the case. I don't think I've seen unixpacket used anywhere TBH (not just deno, but any software project)
There was a problem hiding this comment.
Probably going to get a lot more common with QUIC / HTTP/3.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Windows supports unix sockets since late 2017, this PR simply removes the conditional compilation around unix sockets which should now build and work on all supported platforms.
Should fix #10244
Blocked on
tokio/miosupport for Windows UDS tokio-rs/tokio#2201