docs: Remove references to deprecated types #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoshrousis
commented
Dec 2, 2023
|
|
||
| ```tsx routes/_app.tsx | ||
| import { AppContext } from "$fresh/server.ts"; |
There was a problem hiding this comment.
In the generated code for a new 1.6 fresh project, we get
import { type AppContext } from "$fresh/server.ts";
It is unclear whether the Deno/fresh team prefer import { type over import type syntax, and whether the docs should reflect this.
There was a problem hiding this comment.
I'm neutral on that as both styles are merely a hint to the runtime that the import can be stripped.
marvinhagemeister
approved these changes
Dec 2, 2023
christoshrousis
commented
Dec 2, 2023
Comment on lines
-21
to
31
| import { MiddlewareHandlerContext } from "$fresh/server.ts"; | ||
| import { FreshContext } from "$fresh/server.ts"; | ||
|
|
||
| interface State { | ||
| data: string; | ||
| } | ||
|
|
||
| export async function handler( | ||
| req: Request, | ||
| ctx: MiddlewareHandlerContext<State>, | ||
| ctx: FreshContext<State>, | ||
| ) { | ||
| ctx.state.data = "myData"; |
There was a problem hiding this comment.
The release documentation mentions:
RouteContext (for async routes/layouts/app wrapper)
When I tried to confirm this, and use that typing in this code example, I got a typing error:
Property 'next' does not exist on type 'RouteContext<State>'.deno-ts(2339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the 1.6 release, and commentary by @csvn here, this PR aims to replace the references to deprecated typing in the documentation.
Please see inline commentary for parts I'm unclear on.