Update dependency express to ~4.20.0 [SECURITY]#22
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
Update dependency express to ~4.20.0 [SECURITY]#22renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
5eab5be to
1f58187
Compare
1f58187 to
781d0c6
Compare
781d0c6 to
3c00b01
Compare
3c00b01 to
acfa99d
Compare
acfa99d to
f3bddce
Compare
f3bddce to
dd471c6
Compare
b7f57d0 to
f013261
Compare
f013261 to
fbea567
Compare
fbea567 to
64a741f
Compare
64a741f to
81c0eb1
Compare
81c0eb1 to
8eadc70
Compare
8eadc70 to
9a0fd90
Compare
9a0fd90 to
e54511b
Compare
e54511b to
797dfb1
Compare
97e3f87 to
52112c9
Compare
52112c9 to
130b512
Compare
130b512 to
356b3fc
Compare
356b3fc to
c361d12
Compare
c361d12 to
4923330
Compare
4923330 to
583390a
Compare
583390a to
33fcf45
Compare
33fcf45 to
1288a6f
Compare
1288a6f to
e900677
Compare
e900677 to
8c9f639
Compare
8c9f639 to
758c77d
Compare
758c77d to
5b027fb
Compare
5b027fb to
e920bf8
Compare
e920bf8 to
7dd0578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
~4.13.1→~4.20.0GitHub Vulnerability Alerts
CVE-2024-29041
Impact
Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.
When a user of Express performs a redirect using a user-provided URL Express performs an encode using
encodeurlon the contents before passing it to thelocationheader. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.The main method impacted is
res.location()but this is also called from withinres.redirect().Patches
expressjs/express@0867302
expressjs/express@0b74695
An initial fix went out with
express@4.19.0, we then patched a feature regression in4.19.1and added improved handling for the bypass in4.19.2.Workarounds
The fix for this involves pre-parsing the url string with either
require('node:url').parseornew URL. These are steps you can take on your own before passing the user input string tores.locationorres.redirect.Resources
https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location
CVE-2024-43796
Impact
In express <4.20.0, passing untrusted user input - even after sanitizing it - to
response.redirect()may execute untrusted codePatches
this issue is patched in express 4.20.0
Workarounds
users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist
Details
successful exploitation of this vector requires the following:
Release Notes
expressjs/express (express)
v4.20.0Compare Source
==========
depthoption to customize the depth level in the parserdepthlevel for parsing URL-encoded data is now32(previously wasInfinity)res.redirect\,|, and^to align better with URL specoptions.maxAgeandoptions.expirestores.clearCookiev4.19.2Compare Source
==========
v4.19.1Compare Source
==========
v4.19.0Compare Source
==========
v4.18.3Compare Source
==========
partitionedoptionv4.18.2Compare Source
===================
v4.18.1Compare Source
===================
v4.18.0Compare Source
===================
res.downloadoptionswithoutfilenameinres.downloadres.statusnull/undefinedasmaxAgeinres.cookieObject.prototypevalues in settings throughapp.set/app.getdefaultwith same arguments as types inres.formatres.sendhttp-errorsforres.formaterrorstrictpriorityoptionexpiresoption to reject invalid datesevalusage withFunctionconstructorprocessto check for listeners425 Unordered Collectionto standard425 Too Earlyv4.17.3Compare Source
===================
__proto__keysv4.17.2Compare Source
===================
undefinedinres.jsonpundefinedwhen"json escape"is enabledRegExpsres.jsonp(obj, status)deprecation messageres.isJSDocmaxAgeoption to reject invalid valuesreq.socketover deprecatedreq.connectionv4.17.1Compare Source
===================
null/undefinedtores.status"v4.17.0Compare Source
===================
express.rawto parse bodies intoBufferexpress.textto parse bodies into stringres.sendFilenull/undefinedtores.statusX-Forwarded-Hostpb) supportSameSite=NonesupportContent-Security-Policyheaderpath.normalizecall103 Early Hintsthrowon invalid typev4.16.4Compare Source
===================
"Request aborted"may be logged inres.sendfileRouterconstructorv4.16.3Compare Source
===================
%as last characterv4.16.2Compare Source
===================
TypeErrorinres.sendwhen givenBufferandETagheader setX-Forwarded-Protoheaderv4.16.1Compare Source
===================
rootis incorrectly set to a filev4.16.0Compare Source
===================
"json escape"setting forres.jsonandres.jsonpexpress.jsonandexpress.urlencodedto parse bodiesoptionsargument tores.downloadBufferencoding when not generating ETag for small responsesafe-bufferfor improved Buffer APIres.headersSentwhen availableRegExpX-Forwarded-ForX-Forwarded-Forheaderimmutableoption</html>in default error & redirectsimmutableoption.charsetset inres.jsonpv4.15.5Compare Source
===================
If-None-Matchtoken parsingIf-Matchtoken parsingv4.15.4Compare Source
===================
Bufferloadingv4.15.3Compare Source
===================
res.setcannot add charset toContent-TypeDEBUG_MAX_ARRAY_LENGTH</html>in HTML documentv4.15.2Compare Source
===================
[v4.15.1Compare Source
===================
Date.parsedoes not returnNaNon invalid dateDate.parsedoes not returnNaNon invalid datev4.15.0Compare Source
===================
next("router")to exit from routerrouter.useskipped requests routes did notres._headersprivate fieldreq.urlis not set%oin path debug to tell types apartObject.createto setup request & response prototypessetprototypeofmodule to replace__proto__settingstatusesinstead ofhttpmodule for status messagesDEBUG_FDenvironment variable set to3or highererrcannot be converted to a stringContent-Security-Policy: default-src 'self'headerno-cacherequest directiveIf-None-Matchhas both*and ETagsETagmatching to match specIf-None-Matchwhen noETagheaderDate.parseinstead ofnew Dateno-cacherequest directiveIf-None-Matchhas both*and ETagsETagmatching to match specres._headersprivate fieldIf-MatchandIf-Unmodified-Sinceheadersres.getHeaderNames()when availableres.headersSentwhen availableno-cacherequest directiveIf-None-Matchhas both*and ETagsETagmatching to match specres._headersprivate fieldIf-MatchandIf-Unmodified-Sinceheadersres.getHeaderNames()when availableres.headersSentwhen available*routereq.ipsperformancev4.14.1Compare Source
===================
err.headersis not an objectv4.14.0Compare Source
===================
acceptRangesoption tores.sendFile/res.sendfilecacheControloption tores.sendFile/res.sendfileoptionsargument toreq.rangecombineoptionres.location/res.redirectif not already encodedres.sendFile/res.sendfilereq.get()res.json/res.jsonpin most casesRangeheader handling inres.sendFile/res.sendfileAcceptparsingAcceptparameters with quoted equalsAcceptparameters with quoted semicolonssameSiteoptionMax-Ageto never be a floating point numberencodeis not a functionexpiresis not aDateserializeerr.statusCodeiferr.statusis invaliderr.headersobjectstatusesinstead ofhttpmodule for status messagesdecoderoption inparsefunctioncombineoption to combine overlapping rangesacceptRangesoptioncacheControloptionStreamclassContent-Rangeheader in 416 responses when usingstart/endoptionsContent-Rangeheader missing from default 416 responsespathcontains raw non-URL characterspathstarts with multiple forward slashesRangeheadersacceptRangesoptioncacheControloptionreq.urlcontains raw non-URL charactersRangeheadersfieldargumentv4.13.4Compare Source
===================
serializev4.13.3Compare Source
===================
mergeParams: truereq.paramsv4.13.2Compare Source
===================
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.