Improve CmpDocument Model Validations #23468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Validate that vbms_doctype_id is an integer. - Improve validation of date_of_receipt to be less lenient in parsing dates and require that they follow yyyy-mm-dd format.
tradesmanhelix
commented
Nov 8, 2024
tradesmanhelix
commented
Nov 8, 2024
zurbergram
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Create CMP Document metadata endpoint
Description
Acceptance Criteria
Testing Plan
bundle exec rspec spec/models/cmp_document_spec.rbbundle exec rspec spec/models/cmp_mail_packet_spec.rbbundle exec rspec spec/requests/api/v1/cmp_controller_spec.rb